Skip to content

DeepCompare(...): memoize array lengths #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2018
Merged

DeepCompare(...): memoize array lengths #30

merged 2 commits into from
Jul 11, 2018

Conversation

dtivel
Copy link
Collaborator

@dtivel dtivel commented Jun 29, 2018 •
edited
Loading

Resolve #29.

Using the repro in the issue before and after this change, I see an ~82% improvement.

Trial Before (seconds) After (seconds)
1 4.7120547 0.8858446
2 4.4700995 0.7774562
3 4.7587833 0.718364
4 4.4111438 0.7194454
5 4.6068476 0.7290612
6 4.4516934 0.9075534
7 4.5342458 1.0242339
8 4.9928839 0.7582783
9 4.8472956 0.7843428
10 4.6274842 0.7340139
Average 4.64125318 0.80385937

Also fixing an issue in build.ps1 where an error would be reported if a directory did not exist when calling Remove-Item (rm) on it.

All tests pass.

@goofballLogic
Copy link
Member

Confirmed tests pass

@goofballLogic goofballLogic merged commit c0d3b8f into linked-data-dotnet:master Jul 11, 2018
@dtivel dtivel mentioned this pull request Jul 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JsonLdUtils.DeepCompare(...): poor performance on large arrays
2 participants
@dtivel @goofballLogic